import json import pytest from app.discovery import TaskCatalog from app.inputs import validate_inputs from app.web import create_app from .conftest import write_task @pytest.fixture def checkbox_task(settings): task = write_task(settings.task_root, "example", "inspect.py", 'print("done")\n') manifest = {"version": 1, "tasks": {task.name: {"inputs": [{ "name": "operations", "label": "Operations", "type": "multi_choice", "default": ["link", "cleanup"], "options": ["link", "cleanup"], }]}}} (task.parent / "task-inputs.json").write_text(json.dumps(manifest)) return TaskCatalog(settings.task_root).task("example/inspect.py") @pytest.mark.parametrize("submitted,expected", [ ({}, ["link", "cleanup"]), ({"operations": [""]}, []), ({"operations": ["", "link"]}, ["link"]), ({"operations": ["", "cleanup"]}, ["cleanup"]), ({"operations": ["", "link", "cleanup"]}, ["link", "cleanup"]), ]) def test_empty_form_selection_is_not_replaced_with_defaults(checkbox_task, submitted, expected): values, errors = validate_inputs(checkbox_task.inputs, submitted) assert not errors assert values["operations"] == expected def test_required_empty_selection_is_rejected_even_with_defaults(checkbox_task): from dataclasses import replace field = replace(checkbox_task.inputs[0], required=True) values, errors = validate_inputs((field,), {"operations": [""]}) assert values == {} assert errors == {"operations": "Choose at least one option."} @pytest.mark.parametrize("selected", [["", "unknown"], ["", "link", "link"]]) def test_hidden_marker_does_not_bypass_option_validation(checkbox_task, selected): _, errors = validate_inputs(checkbox_task.inputs, {"operations": selected}) assert errors def test_form_contains_empty_marker_and_persists_explicit_empty_selection(settings, checkbox_task): app = create_app(settings) client = app.test_client() assert b'type="hidden" name="operations" value=""' in client.get("/").data response = client.post("/tasks/example/inspect.py/run", data={"operations": ""}) assert response.status_code == 302 run_id = int(response.headers["Location"].rsplit("/", 1)[1]) run = app.extensions["run_store"].get(run_id) assert json.loads(run.input_json) == {"operations": []}