Refine Python tools task interface

python-tools/tests/test_web.py

@@ -213,7 +213,6 @@ print(Path(os.environ["SERVER_MAINTENANCE_INPUT"]).read_text())
             "migrate.py": {
               "execution": {
                 "field": "mode",
-                "label": "Action",
                 "dry_run_value": "report",
                 "dry_run_label": "Report only",
                 "execute_value": "apply",
@@ -230,7 +229,8 @@ print(Path(os.environ["SERVER_MAINTENANCE_INPUT"]).read_text())
     page = client.get("/")
     assert b"Report only" in page.data
     assert b"Apply changes" in page.data
-    assert b"data-execution-mode" in page.data
+    assert b"data-execution-value" in page.data
+    assert b"data-execution-choice" in page.data
     assert b'class="split-button"' in page.data
     response = client.post("/tasks/examples/migrate.py/run")
     run_id = int(response.headers["Location"].rsplit("/", 1)[1])
@@ -294,6 +294,47 @@ print("archive created")
     assert app.extensions["run_manager"].artifact_path(run_id, "review.zip") is None
 
 
+def test_json_artifact_can_be_opened_without_deleting_it(settings) -> None:
+    write_task(
+        settings.task_root,
+        "exports",
+        "report.py",
+        '''"""Creates a report."""
+import os
+from pathlib import Path
+
+artifact = Path(os.environ["SERVER_MAINTENANCE_ARTIFACTS"]) / "report.json"
+artifact.write_text('{"status":"ok"}', encoding="utf-8")
+''',
+    )
+    app = create_app(settings)
+    client = app.test_client()
+
+    response = client.post("/tasks/exports/report.py/run")
+    run_id = int(response.headers["Location"].rsplit("/", 1)[1])
+    deadline = time.monotonic() + 3
+    while time.monotonic() < deadline:
+        run = app.extensions["run_store"].get(run_id)
+        assert run is not None
+        if run.status == "succeeded":
+            break
+        time.sleep(0.01)
+    else:
+        raise AssertionError("JSON artifact task did not finish")
+
+    listed = client.get(f"/runs/{run_id}/artifacts").get_json()
+    artifact = listed["artifacts"][0]
+    assert artifact == {
+        "name": "report.json",
+        "url": f"/runs/{run_id}/artifacts/report.json",
+        "view_url": f"/runs/{run_id}/artifacts/report.json/view",
+    }
+    opened = client.get(artifact["view_url"])
+    assert opened.mimetype == "application/json"
+    assert opened.get_json() == {"status": "ok"}
+    assert app.extensions["run_manager"].artifact_path(run_id, "report.json") is not None
+
+
 def test_file_input_rejects_the_wrong_extension(settings) -> None:
     task = write_task(settings.task_root, "imports", "apply.py", '"""Applies a CSV."""\n')
     (task.parent / "task-inputs.json").write_text(